-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update docs site and README with addition usage info #13
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These docs are fantastic! Had a few comments but they look great to me overall.
README.md
Outdated
|
||
<img alt="Retry message" src="images/messageWithError.png" width=350></img> | ||
|
||
Vectara's chatbot is also ready for use on mobile sites, taking the fullscreen when the chat window is opened: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I think we should change "Vectara's chatbot" to "React-Chatbot".
Spelling: "fullscreen" -> "full screen"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this is why I need you for reviews. 😆 "Vectara's chatbot" is absolutely not ideal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
|
||
_For more information on data ingestion, see our [vectara-ingest](https://github.com/vectara/vectara-ingest) repository._ | ||
|
||
##### isLoading: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should boolean be formatted as code?
`boolean`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
|
||
A boolean value indicating whether or not a chat API request is still pending | ||
|
||
##### hasError: boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
This is an array of objects representing question and answer pairs from the entire conversation. Each pair is a `ChatTurn` object, which is typed as: | ||
|
||
``` | ||
export type ChatTurn = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT of linking to https://github.com/vectara/react-chatbot/blob/main/src/types.ts instead of duplicating the definition here? It will make maintenance easier by reducing the risk of divergence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
}; | ||
``` | ||
|
||
_For more information on data ingestion, see our [vectara-ingest](https://github.com/vectara/vectara-ingest) repository._ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a bit of a non-sequitur. We're already linking to Vectara Ingest in a narrower context, above, so maybe we can remove this bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
|
||
### Usage with SSR Frameworks | ||
|
||
Using React-chatbot with SSR frameworks may require additional infrastucture. Here are some common gotchas: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use this casing consistently: "React-Chatbot".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
908d9f7
to
81e64cf
Compare
CONTEXT
In order to widen the number of developers that can use this module, we offer the
useChat
hook so that user can create their own views. In order to support them, we need to provide guidance for hook usage in the docs site as well as README.CHANGES
error
hook value tohasError
to be more instantly readable as a boolean value.SCREENSHOTS
DOCS SITE CHANGES
README CHANGES
UI SECTION
USECHAT HOOK SECTION